Move a SetEnableAlert call to UICommon #11088
Conversation
This fixes a problem where changing the Use Panic Handlers setting on Android wouldn't take effect until the app was restarted.
Because of the previous commit, this is needed to stop DolphinQt from forgetting that the user pressed ignore whenever any part of the config is changed. This commit also changes the behavior a bit on DolphinQt: "Ignore for this session" now applies to the current emulation session instead of the current Dolphin launch. This matches how it already worked on Android, and is in my opinion better because it means the user won't lose out on important panic alerts in a game becase they played another game first that had repeated panic alerts that they wanted to ignore. For Android, this commit isn't necessary, but it makes the code cleaner.
| @@ -108,6 +110,12 @@ static void InitCustomPaths() | |||
| #endif | |||
| } | |||
|
|
|||
| static void RefreshConfig() | |||
| { | |||
| Common::SetEnableAlert(Config::Get(Config::MAIN_USE_PANIC_HANDLERS)); | |||
There was a problem hiding this comment.
I think this doesn't work like you intended it. If you have Use Panic Handlers on, then click 'ignore for this session' and then change any setting, it would re-enable the panic handlers. We probably need to split the current session boolean from the setting boolean here.
There was a problem hiding this comment.
That's what the second commit fixes.
There was a problem hiding this comment.
Ooh I see, you do this via the config layering system, I missed that. Makes sense.
|
I think this ends up deadlocking itself in Single Core because the call to |
|
Ah, hold on, this is more nefarious. I was testing https://github.com/dolphin-emu/dolphin/pull/11119/files#diff-354a123faea2cf2907f8934821753bd6541a31399140f21e440767e64f662a51R403 this PanicAlert but that actually happens on the Vulkan CommandBufferManager SubmitThread, not the CPU thread. |
|
Okay yeah, this is actually a deadlock between the CPU thread calling WaitForWorkerThreadIdle() (in Renderer::Swap()) and the waited-for worker thread calling PauseAndLock() (from the SetCurrent()). I hate panic alerts. |
This fixes a problem where changing the Use Panic Handlers setting on Android wouldn't take effect until the app was restarted.