NetworkCaptureLogger: Allow PCAP shared read access on Windows #11089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Sep 29, 2022
Source/Core/Common/IOFile.cpp
Outdated
| @@ -62,12 +63,20 @@ void IOFile::Swap(IOFile& other) noexcept | |||
| std::swap(m_good, other.m_good); | |||
| } | |||
|
|
|||
| bool IOFile::Open(const std::string& filename, const char openmode[]) | |||
| bool IOFile::Open(const std::string& filename, const char openmode[], SharedAccess sh) | |||
There was a problem hiding this comment.
Should this perhaps log anything out on non-windows systems that the passed in shared access will be ignored?
Maybe sh should be tagged as [[maybe_unused]] as well
Aside from that one concern, everything looks good to me
There was a problem hiding this comment.
Should this perhaps log anything out on non-windows systems that the passed in shared access will be ignored?
It won't be necessary since it's the default behaviour on the other systems (i.e. Default == Read). I can already access the PCAP file from Linux and Android builds since fopen/fdopen don't lock the file. Unlike Windows' fopen_s that doesn't allow share read.
Maybe
shshould be tagged as[[maybe_unused]]as well
Done.
sepalani
force-pushed
the
pcap-share
branch
from
2efc7ac
to
481ddd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR allows shared read access of PCAP file being dumped so we don't have to wait the dump to be finished (i.e. shutdown the game) to read it on Windows.
Ready to be reviewed & merged.