Android: Use view binding #11092
Merged
Android: Use view binding #11092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t895
force-pushed
the
view-binding
branch
2 times, most recently
from
bee575c
to
e60dc31
Compare
t895
force-pushed
the
view-binding
branch
3 times, most recently
from
57e6ab4
to
df50769
Compare
JosJuice
reviewed
Oct 23, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/dialogs/GameDetailsDialog.java
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
Oct 23, 2022
...oid/app/src/main/java/org/dolphinemu/dolphinemu/features/cheats/ui/CheatDetailsFragment.java
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
Oct 23, 2022
...ndroid/app/src/main/java/org/dolphinemu/dolphinemu/features/cheats/ui/CheatListFragment.java
Show resolved
Hide resolved
JosJuice
reviewed
Oct 23, 2022
.../Android/app/src/main/java/org/dolphinemu/dolphinemu/features/cheats/ui/CheatViewHolder.java
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
Oct 23, 2022
...e/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/cheats/ui/CheatsActivity.java
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
Oct 23, 2022
...p/src/main/java/org/dolphinemu/dolphinemu/features/riivolution/ui/RiivolutionViewHolder.java
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
Oct 23, 2022
...ndroid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
Oct 23, 2022
...ava/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/CheckBoxSettingViewHolder.java
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
Oct 23, 2022
...ain/java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/FilePickerViewHolder.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/HeaderViewHolder.java
Outdated
Show resolved
Hide resolved
...org/dolphinemu/dolphinemu/features/settings/ui/viewholder/InputBindingSettingViewHolder.java
Outdated
Show resolved
Hide resolved
.../org/dolphinemu/dolphinemu/features/settings/ui/viewholder/InputStringSettingViewHolder.java
Outdated
Show resolved
Hide resolved
.../java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/RumbleBindingViewHolder.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainActivity.java
Outdated
Show resolved
Hide resolved
...e/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/platform/PlatformGamesFragment.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/viewholders/GameViewHolder.java
Outdated
Show resolved
Hide resolved
t895
force-pushed
the
view-binding
branch
2 times, most recently
from
6b4b73b
to
62b0753
Compare
JosJuice
reviewed
Oct 29, 2022
...c/main/java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/SettingViewHolder.java
Outdated
Show resolved
Hide resolved
JosJuice
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
View binding is the successor to findViewById and ButterKnife injection. It is faster, reduces compile times, and has null/type safety. There aren't any visible changes in this PR besides some very slight text alignment changes in the convert activity.
More information about what view binding does and how to use it - https://developer.android.com/topic/libraries/view-binding#java
Note - These changes will not remove findViewById from the CustomTitleView for the TV layout nor the custom file picker due to limitations with leanback and nononsensefilepicker