Remove special treatment for Android in video settings

[K0bin]

Having a submission thread with Vulkan is common practice and recommended basically everywhere. I'd expect most Vulkan apps on Android to have one, so I don't see why this is disabled on Android. The more frequent flushing is only done when there are CPU readbacks (for example EFB peeks) and giving the GPU a head start in those cases is definitely beneficial too.
This relies on #11090 to not slow things down.

[JosJuice]

You need to update the default value of the setting here too:

dolphin/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.java

Line 200 in 299aef9

"BackendMultithreading", false),

[TellowKrinkle]

Did you notice the flush helping with anything? We should already do it after encoding a download in the vertex manager:

dolphin/Source/Core/VideoCommon/VertexManagerBase.cpp

Line 847 in 9ca1c0f

g_renderer->Flush();

[K0bin]

We should already do it after encoding a download in the vertex manager:

No, the vertex manager flushes at specific points before the draw calls that are just before a readback in previous frames.

Did you notice the flush helping with anything?

It didn't really. For some reason, syncing on EFB copies and peeks is still quite a bit slower with Vulkan than GL.

[TellowKrinkle]

No, the vertex manager flushes at specific points before the draw calls that are just before a readback in previous frames.

With deferred readbacks on, it should flush after each readback unless there's a bunch in a row
Otherwise, it immediately waits for the readback to complete, which forces a flush
Either way, a flush is immediate in both cases with the exception of those specific cases in deferred readbacks. If those are an issue, we should be solving this by adjusting that, not throwing extra flushes into the Vk backend.

[K0bin]

I dropped the flush commit.

[iwubcode]

11090 was merged, can this be rebased?

[iwubcode]

Code wise LGTM. Someone needs to test though, I don't have any Android devices.

[K0bin]

11090 was merged, can this be rebased?

GitHub says it doesn't need a rebase. It also doesn't touch the same parts as that PR.

[brujo5]

It work fine on my poco X3 pro. I have not had any regression. except that Vulkan is no longer that far behind OpenGL.

[Pokechu22]

See #7739 for when this was originally added. It looks like there's still an outdated comment from that PR:

dolphin/Source/Android/app/src/main/res/values/strings.xml

Line 342 in c196c47

<string name="backend_multithreading">Backend Multithreading</string> <!--Backend Multithreading is only disabled by default on Android -->

[Pokechu22]

Code looks fine to me now, but the commit/PR message should probably use "special cases" instead of "exceptions" to avoid confusion with C++ exceptions or similar. Maybe "Remove Android special-cased default settings"?

[golivax]

Just wanted to mention that, for the first time, Skyward Sword runs at full speed on a SD855 using the Vulkan Backend. Awesome job, folks!