Fix bug in PrintCallstack caused by trying to use MMIO #111
+63
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| u32 addr = Memory::ReadUnchecked_U32(PowerPC::ppcState.gpr[1]); // SP | ||
|
|
||
| // Walk the stack chain | ||
| while ((addr != 0xFFFFFFFF) && |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I'm not terribly happy with the code duplication of the "walk stack chain" loop there; but its a bit hard to review on GH. Maybe we can pull that out into a helper method or smth? |
| bool addr_is_bottom = std::find(std::begin(stack_bottom_indicators), | ||
| std::end(stack_bottom_indicators), addr) | ||
| != std::end(stack_bottom_indicators); | ||
| return addr_is_bottom || !Memory::IsRAMAddress(addr); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Also tidy up methods in Debugger_SymbolMap.cpp
delroth
added a commit
that referenced
this pull request
Mar 8, 2014
Fix bug in PrintCallstack caused by trying to use MMIO
hrydgard
referenced
this pull request
Mar 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Also tidy up methods in Debugger_SymbolMap.cpp