EXI_DeviceMemoryCard: Drop comment about ChipErase behaviour #11104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on an official DOL-014 (251 blocks) memory card by executing the 0xf4 command on a card with content along its entire length and then dumping the whole card: it reads as 0xff all the way through. Therefor, the current implementation is already consistent with hardware.
|
Reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on an official DOL-014 (251 blocks) memory card by executing the 0xf4 command on a card with content along its entire length and then dumping the whole card: it reads as 0xff all the way through. Therefor, the current implementation is already consistent with hardware.