Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI: Ignore non-standard setGameID command #11105

Merged
merged 1 commit into from Nov 16, 2022

Conversation

vpelletier
Copy link
Contributor

Avoids a panic when loading recent swiss. Not enough to have it run, unfortunately.

@AdmiralCurtiss
Copy link
Contributor

Do you know what happens on hardware for this command?

@Pokechu22
Copy link
Contributor

This functionality was added by @Extrems in emukidid/swiss-gc@b6aec69. As far as I can tell, this is a custom command used for an N64 hardware mod (and not one that's for modded controllers, either). I'm not how regular hardware reacts to unknown commands, if it does anything. (I'm also not sure if this mod even makes sense on the GameCube/Wii, but to my understanding SI is the same between the N64 and GameCube so the same protocol applies.)

@Extrems
Copy link

Extrems commented Sep 28, 2022

Licensed accessories simply don't respond, and this is actually for BlueRetro.

@AdmiralCurtiss
Copy link
Contributor

This info should probably be mentioned in the comments for this command then.

Avoids a panic when loading recent swiss. Not enough to have it run,
unfortunately.
@vpelletier
Copy link
Contributor Author

Thanks for the review.

This info should probably be mentioned in the comments for this command then.

I have extended the comment to include this piece of information.

@AdmiralCurtiss AdmiralCurtiss merged commit 43e90ca into dolphin-emu:master Nov 16, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants