JitArm64: Fix divwx BindToRegister condition #11114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a is being used both as an immediate and as a register here. Since it's being used as a register, it must be loaded.
|
Nice catch! |
|
@JosJuice do you have Rogue Squadron? It still has a black screen. F-Zero was fixed though. edit: from the console |
|
Is this Rogue Squadron 2 or Rogue Squadron 3? I don't have Rogue Squadron 2, but Rogue Squadron 3 works for me. |
|
It’s RS2. |
|
I've pushed an untested second commit that may or may not help with the RS2 problem. |
JosJuice
force-pushed
the
jitarm64-divwx-imm
branch
from
2be1def
to
319bb12
Compare
|
No dice. |
|
Yeah, now that I look more closely, the second commit doesn't actually fix anything. But it makes the code less fragile in case the behavior of the register cache were to change in the future, so I think I'll keep it. |
In case the register we're binding is the same as the immediate register, we should fetch the immediate before calling BindToRegister. The way the register cache currently works, calling GetImm after BindToRegister actually does work, but it's better to not rely on it.
JosJuice
force-pushed
the
jitarm64-divwx-imm
branch
from
319bb12
to
8984777
Compare
|
Probably not a good idea to leave this broken for long, and this looks reasonable to me, so... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
a is being used both as an immediate and as a register here. Since it's being used as a register, it must be loaded. Fixes an F-Zero GX regression from PR #11094.