JitArm64: Fix BindToRegister in case Immediate && !set_dirty #11117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes RS2 on JITARM |
Fixes a Rogue Squadron II regression from 9d73583. This set_dirty stuff is pretty tricky to reason about. I thought I was clever when coming up with set_dirty, but maybe I was too clever for my own good...
JosJuice
force-pushed
the
jitarm64-imm-not-dirty
branch
from
d37f820
to
42775ee
Compare
|
Confirmed working. Awesome, thanks! |
Sintendo
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes a Rogue Squadron II regression from PR #11094.
This
set_dirtystuff is pretty tricky to reason about. I thought I was clever when coming up withset_dirty, but maybe I was too clever for my own good...