Vulkan/CommandBufferManager: Show error code in PanicAlerts. #11119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
reviewed
Oct 4, 2022
| @@ -303,7 +303,7 @@ void CommandBufferManager::SubmitCommandBuffer(bool submit_on_worker_thread, | |||
| if (res != VK_SUCCESS) | |||
| { | |||
| LOG_VULKAN_ERROR(res, "vkEndCommandBuffer failed: "); | |||
| PanicAlertFmt("Failed to end command buffer"); | |||
| PanicAlertFmt("Failed to end command buffer: {} ({})", VkResultToString(res), res); | |||
There was a problem hiding this comment.
LOG_VULKAN_ERROR uses static_cast<int>(res), but that probably isn't necessary.
I was going to suggest that it might be better to print it as {:08x}, but it looks like the docs show them in decimal. So this is probably good as-is.
AdmiralCurtiss
force-pushed
the
vulkan-panic-alerts
branch
from
6c9e09c
to
eea31db
Compare
Pokechu22
approved these changes
Oct 4, 2022
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
iwubcode
approved these changes
Oct 4, 2022
|
FWIW I don't think this will be particularly useful. The error code is most likely just gonna be VK_ERROR_DEVICE_LOST. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
So people will actually tell us the error code when this happens. (https://bugs.dolphin-emu.org/issues/13060)