Include tangent/binormal cache in savestates and simplify saving CP state #11131
+12
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
force-pushed
the
cp-state-savestate-mistakes
branch
from
178ecaf
to
79f9401
Compare
This theoretically matters for RS2/RS3, although in practice these games reconfigure it each frame so it shouldn't matter for savestates.
Pokechu22
force-pushed
the
cp-state-savestate-mistakes
branch
from
79f9401
to
92b4196
Compare
| @@ -123,6 +123,7 @@ struct entry | |||
|
|
|||
| void MarkAllDirty() | |||
| { | |||
| g_bases_dirty = false; | |||
Rather than makring some parts of VertexLoaderManager dirty in some places and some in others, do it all in VideoState. Also, since CPState no longer contains pointers/non-CP data after d039b1b, we can just use p.Do on it instead of manually saving each field.
Pokechu22
force-pushed
the
cp-state-savestate-mistakes
branch
from
92b4196
to
ffed23c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The tangent/binormal cache theoretically matters for RS2/RS3 (see #10584), although in practice these games reconfigure it each frame so it shouldn't matter for savestates.
The CP state part is simplification only; there should be no change in behavior from it.