Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JitCache: Erase address from noSpeculativeConstantsAddresses when block is invalidated. #11133

Merged

Conversation

AdmiralCurtiss
Copy link
Contributor

I'm not sure if there's any particular reason this isn't done? This looked wrong to me skimming over it the code, at least.

@AdmiralCurtiss AdmiralCurtiss changed the title Jit64: Erase address from noSpeculativeConstantsAddresses when block is invalidated. JitCache: Erase address from noSpeculativeConstantsAddresses when block is invalidated. Oct 8, 2022
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • mkdd-efb on uberogl-lin-radeon: diff

automated-fifoci-reporter

@JosJuice JosJuice merged commit 934349a into dolphin-emu:master Oct 8, 2022
11 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the noSpeculativeConstantsAddresses branch October 8, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants