PPCAnalyst: Remove unused variables and methods in BlockStats and BlockRegStats. #11135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the first commit: Yeah, I'm guessing it was used for register allocation or something. Removing it seems fine (if someone wants it back for register allocation changes they can always grab it from the git history), but... Since the struct now consists of a single bool, should it really be a struct anymore? Regarding the second commit: That code does actually do something, even if it's just to be shown in the debugger. Perhaps we should keep it. |
Does it? Both variables are never set to |
|
Ah. Good point :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
None of this seems to be used for anything. I'm guessing it was used at some point in the past?