Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoBackends:Vulkan: Fix command buffer cleanup #11143

Merged
merged 1 commit into from Oct 8, 2022

Conversation

K0bin
Copy link
Contributor

@K0bin K0bin commented Oct 8, 2022

#11090 had a subtle bug that broke deferred freeing of Vulkan resources.

This led to rapid increase in memory usage in Opoona until OOM because Dolphin allocates new textures every single frame for that game.

@iwubcode

Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fixed (tested DKCR too). Code LGTM, I should have caught that before..sorry. Appreciate the quick turn around @K0bin !

@AdmiralCurtiss AdmiralCurtiss merged commit 1dd30b5 into dolphin-emu:master Oct 8, 2022
11 checks passed
@K0bin K0bin deleted the cmd_buffer_cleanup-fix branch October 8, 2022 20:33
@K0bin
Copy link
Contributor Author

K0bin commented Oct 9, 2022

@brujo5 Impossible to say without investigating it.

Which game does this happen with and does it only happen with a development build of Dolphin or the play store version too?

@JMC47
Copy link
Contributor

JMC47 commented Oct 9, 2022

If it happens in the play store build, then it's not related to this pull request. Please use the proper channels to report issues instead of posting in unrelated areas. If you keep posting here instead of on an issue report (https://bugs.dolphin-emu.org/projects/emulator) or some other support channel like the dolphin-emu irc on libera chat, you may be blocked from posting on the project. Thanks in advance.

@brujo5
Copy link

brujo5 commented Oct 9, 2022

@JMC47 that's true, my problem has nothing to do with this PR, this creates confusion, so I delete the messages and an apology in advance. thx

@JMC47
Copy link
Contributor

JMC47 commented Oct 9, 2022

No need to apologize, I just wanted to let you know as we've had some rather unfortunate incidents in the past with users refusing to use the issue tracker or spamming random pull requests. This one is at least related to vulkan, so I get why the confusion might exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants