DolphinQt: Make "All Devices" mapping hopefully less confusing.

[jordan-woyak]

The "All devices" option in the device list is confusing.
It's not a device selection. It only changes the behavior for the mapping buttons, allowing them to produce "full-path" input expressions for the non-selected device.
e.g. With "Keyboard Mouse" selected you can press a button on your PS5 controller to create an SDL/0/PS5 Controller:Button 2 input expression with "All devices" activated.

I've moved the feature to a menu of the "Refresh" button to hopefully make it more apparent that it is a configuration mode and not a device selection.
The feature is disabled every time the dialog is opened (same as old behavior).

[JMC47]

this is 100% better. I don't think it's perfect, but I will take this in a heartbeat over the current situation.

[mbc07]

I agree it's better, but I'm not sure if I would group it together with the "Refresh" button. The two options seems different enough that at a first glance I definitely wouldn't think of going there to find the "all devices" checkbox.

Making that "create mappings for other devices" its own checkbox and placing it right below the device dropdown control is more intuitive and would solve that, but then it would create a second empty line in the adjacent groups (Reset and Profile) and I'm not sure if that is necessarily better than the currently proposed approach ¯\_(ツ)_/¯

[jordan-woyak]

I agree it's better, but I'm not sure if I would group it together with the "Refresh" button. The two options seems different enough that at a first glance I definitely wouldn't think of going there to find the "all devices" checkbox.

Making that "create mappings for other devices" its own checkbox and placing it right below the device dropdown control is more intuitive and would solve that, but then it would create a second empty line in the adjacent groups (Reset and Profile) and I'm not sure if that is necessarily better than the currently proposed approach ¯_(ツ)_/¯

I agree that it's strange to hide behind the "Refresh" button but I didn't want to clutter the dialog even more.
The "Refresh" text could be changed to "Options" which contained "Refresh" and the new "Create mappings for other devices"?

[AdmiralCurtiss]

We could do something like, put a checkbox next to the Refresh button and move the Profile box into a second row, maybe? I've always been annoyed at how little space there is for the profile name in the default window width anyway, so maybe we can fix two things at once here.

[iwubcode]

I've always been annoyed at how little space there is for the profile name in the default window width anyway, so maybe we can fix two things at once here.

Yes please! Me too.

Though the profile menu needs an overhaul in general. I recall @jordan-woyak and I talking about this, I know it involved a sub-menu (but the details elude me and it looks like I forgot to take notes). Regardless, this would be a good intermediate step.

EDIT: found my discussion, will copy to my notes :)

[AdmiralCurtiss]

Well I guess I'll just merge this, we can always improve the UI further later...