HW: Use unsigned indices in RegisterMMIO where applicable #11155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base is an unsigned variable, so we can make things little more consistent by making the loop index unsigned so we aren't doing bit arithmetic with signed types. MemoryInterface already does this, so we can leave it alone. No behavioral changes, just a consistency thing.
JosJuice
approved these changes
Oct 11, 2022
Pokechu22
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
baseis an unsigned variable, so we can make things little more consistent by making the loop index unsigned so we aren't doing bit arithmetic with signed types.Some other RegisterMMIO calls already use unsigned values for this sort of thing, so those don't need to be touched
No behavioral changes, just a nitpicky consistency thing.