Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated SoulCalibur 2 ini. #11156

Merged
merged 1 commit into from Oct 22, 2022
Merged

Conversation

dvessel
Copy link
Contributor

@dvessel dvessel commented Oct 11, 2022

Fast texture cache samples and immediate xfb has no ill effects.

This is a fighting game so having the option to enable immediate xfb would be nice.

It was bulk added in 3fbb9d6, so I have no clue why it was added.

@Pokechu22
Copy link
Contributor

Pokechu22 commented Oct 11, 2022

UseXFB = True and UseRealXFB = False was replaced with ImmediateXFBEnable = False in c580104, but I'm not sure if the old values made sense. The wiki links to a bug that says the copy filter is used for fades, but I don't know what the old UseXFB setting did (and I think immediate XFB still works with the copy filter).

I do see one other issue:

# GRSEAF, GRSPAF - SOULCALIBUR2

should instead be

# GRSEAF, GRSPAF, GRSJAF - Soulcalibur II

@dvessel
Copy link
Contributor Author

dvessel commented Oct 11, 2022

I’ve forced these settings for a while and it has never giving me problems. The fades still work.

Fixed the game id’s and title.

@mbc07
Copy link
Contributor

mbc07 commented Oct 11, 2022

Why not just delete the INI file altogether? It's essentially empty and not overriding anything after dropping SafeTextureCacheColorSamples and ImmediateXFBEnable. AFAICT, all INI files shipped with Dolphin overrides something, there are no empty INIs...

@JosJuice
Copy link
Member

Yes, if you're going to be removing both of those settings you should delete the file entirely.

Fast texture cache samples and immediate xfb has no ill effects.
@dvessel
Copy link
Contributor Author

dvessel commented Oct 11, 2022

I missed that. I was skimming through the other ini files with a bunch of headers with empty values so I just deleted the values.

@Pokechu22
Copy link
Contributor

Does the updater correctly handle deleting files?

@mbc07
Copy link
Contributor

mbc07 commented Oct 11, 2022

Does the updater correctly handle deleting files?

Yep, it does.

@Pokechu22
Copy link
Contributor

Aright, this change is probably good to go then (but I'll hold back on approving it since I don't own SoulCalibur 2 myself).

@dvessel
Copy link
Contributor Author

dvessel commented Oct 11, 2022

Don’t think this is a popular title so here’s a video addressing the issue tracker

What's the problem? Describe what went wrong in few words.
The fade-in and fade-out effects in the game don't show up. In certain sequences, the game uses fade-to-black and fade-from-black effects when transitioning between scenes. Two examples I can think of:

  • The title screen of the game. After the opening FMV sequence to the game is skipped or ends, the title screen pops out of nowhere.
  • In an Arcade Mode run, after the victory sequence, the screen immediately jumps from the shot of the pose

What did you expect to happen instead?

  • The title screen should fade in from black, rather than the jarring transition that it is now
  • Similarly, in the arcade mode transition to the next fight, there should be a quick fade-to-black at the end of the victory sequence, followed by a quick fade-in to the next match's versus screen.
sc2.mov

Everything fades into each other as expected.

Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine.

@JMC47 JMC47 merged commit 091b448 into dolphin-emu:master Oct 22, 2022
11 checks passed
@dvessel dvessel deleted the soulcalibur2ini branch November 7, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants