New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated SoulCalibur 2 ini. #11156
Outdated SoulCalibur 2 ini. #11156
Conversation
|
I do see one other issue: dolphin/Data/Sys/GameSettings/GRS.ini Line 1 in 0c09eb5
should instead be # GRSEAF, GRSPAF, GRSJAF - Soulcalibur II |
3d251dd
to
83c50d7
Compare
|
I’ve forced these settings for a while and it has never giving me problems. The fades still work. Fixed the game id’s and title. |
|
Why not just delete the INI file altogether? It's essentially empty and not overriding anything after dropping |
|
Yes, if you're going to be removing both of those settings you should delete the file entirely. |
Fast texture cache samples and immediate xfb has no ill effects.
83c50d7
to
cada690
Compare
|
I missed that. I was skimming through the other ini files with a bunch of headers with empty values so I just deleted the values. |
|
Does the updater correctly handle deleting files? |
Yep, it does. |
|
Aright, this change is probably good to go then (but I'll hold back on approving it since I don't own SoulCalibur 2 myself). |
|
Don’t think this is a popular title so here’s a video addressing the issue tracker
sc2.movEverything fades into each other as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine.
Fast texture cache samples and immediate xfb has no ill effects.
This is a fighting game so having the option to enable immediate xfb would be nice.
It was bulk added in 3fbb9d6, so I have no clue why it was added.