Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GNUInstallDirs for installation paths #11157

Merged
merged 1 commit into from Feb 1, 2023

Conversation

h3xx
Copy link
Contributor

@h3xx h3xx commented Oct 11, 2022

Lets the user override the sane defaults from GNUInstallDirs.

More information on GNUInstallDirs: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

User-facing changes to configuration step:

  • Use -DCMAKE_INSTALL_BINDIR=... instead of -Dbindir=...
  • Use -DCMAKE_INSTALL_MANDIR=... instead of -Dmandir=...

If you specify none of these options, the installation paths should be the exact same.

Copy link
Contributor

@Zopolis4 Zopolis4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM-- sensible usage of GNUInstallDirs as far as I'm concerned, better way for users to define these directories rather than overriding our internal variables, and install directories are still the same as before.

@AdmiralCurtiss
Copy link
Contributor

Needs a rebase.

@AdmiralCurtiss AdmiralCurtiss merged commit 69b178e into dolphin-emu:master Feb 1, 2023
14 checks passed
@h3xx h3xx deleted the use-gnuinstalldirs branch February 1, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants