VertexLoader: Remove "too many initializer values" workaround functions #11160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally added these in 2b1d103, for both the TPipelineFunction and the size. The size was moved into the header in fdcd2b7 (making the size functions obsolete), but it seems that the functions themselves are no longer needed now. I think I didn't use this approach before because it would have required ComponentFormatTable and ComponentCountRow to be templated, which would end up resulting in lines that were too long and thus wrapped in awkward places. (I *think* they didn't get inferred properly.) Now that we only need TPipelineFunction, the templating is not needed, and this ends up being a more readable version of the version with the wrapper functions.
Pokechu22
force-pushed
the
vertexloader-no-initializer-workaround-functions
branch
from
82ef24d
to
581a575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I originally added these in 2b1d103 (#9718), for both the
TPipelineFunctionand the size. The size was moved into the header in fdcd2b7 (#11066) (making the size functions obsolete), but it seems that the functions themselves are no longer needed now.I think I didn't use this approach before because it would have required
ComponentFormatTableandComponentCountRowto be templated, which would end up resulting in lines that were too long and thus wrapped in awkward places. (I think they didn't get inferred properly.) Now that we only needTPipelineFunction, the templating is not needed, and this ends up being a more readable version of the version with the wrapper functions.This PR replaces #11159.