Remove most uses of StringFromFormat in favor of fmt #11162
Conversation
Pokechu22
force-pushed
the
less-StringFromFormat
branch
from
ef73fcc
to
5766f4c
Compare
| @@ -50,7 +52,7 @@ bool CEXIETHERNET::TAPNetworkInterface::Activate() | |||
| const int MAX_INTERFACES = 32; | |||
| for (int i = 0; i < MAX_INTERFACES; ++i) | |||
| { | |||
| strncpy(ifr.ifr_name, StringFromFormat("Dolphin%d", i).c_str(), IFNAMSIZ); | |||
| strncpy(ifr.ifr_name, fmt::format("Dolphin{}", i).c_str(), IFNAMSIZ); | |||
There was a problem hiding this comment.
Is there a reason this isn't done with fmt::format_to? This seems like something that should work.
There was a problem hiding this comment.
format_to and format_to_n never write a null terminator, and I'm not sure if one is needed in this case, so it seemed safer to stick with the original implementation. (Though strncpy also does not write a null terminator if the original string is longer than the buffer size.)
There was a problem hiding this comment.
It's probably fine, ifr is zero'd before doing this. Just an observation, since other places do use it; feel free to leave it like that if nobody else has an opinion on it.
There was a problem hiding this comment.
I didn't see that earlier zeroing out; I've changed it to format_to_n.
Pokechu22
force-pushed
the
less-StringFromFormat
branch
from
5766f4c
to
1c932f3
Compare
Nothing currently uses it. It could theoretically be replaced with fmt support, but I don't think the LOG_VULKAN_ERROR macro is that useful and it'd be better to replace it with regular logging instead.
Pokechu22
force-pushed
the
less-StringFromFormat
branch
from
1c932f3
to
ae7b148
Compare
StringFromFormatusesprintfstrings. There are still 2 remaining places where it is used: CubebUtils.cpp (where it's formatting a printf-style message from a library) and HLE_OS.cpp (where it's formatting a printf-style message from games).