Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Replace spinners with dropdown menus #11163

Merged
merged 1 commit into from Oct 23, 2022

Conversation

t895
Copy link
Contributor

@t895 t895 commented Oct 13, 2022

I finally got around to adapting the "spinners"/dropdown menus to material components. Here's the new looks in the Convert and Riivolution activities.

Riivolution

Old
oldriivolution
New
new riivolution

Convert

Old
oldconvert
New
newconvert

@MayImilae
Copy link
Contributor

MayImilae commented Oct 13, 2022

This is better. Design LGTM.

@cobalt2727
Copy link

Wouldn't it make more sense to have boolean settings a checkbox instead of Enabled/Disabled? Less button presses to get things done.

@t895
Copy link
Contributor Author

t895 commented Oct 23, 2022

Wouldn't it make more sense to have boolean settings a checkbox instead of Enabled/Disabled? Less button presses to get things done.

I would agree with you but there are settings that have more than just Enabled/Disabled

@mbc07
Copy link
Contributor

mbc07 commented Oct 23, 2022

I always thought that was weird. Definitely not a blocker for this PR but it would be nice if the settings where enabled/disabled are the only states could be replaced with checkboxes (even better if they could be replaced with on/off toggles -- I think they're called radio switches, not sure)...

@t895
Copy link
Contributor Author

t895 commented Oct 23, 2022

I always thought that was weird. Definitely not a blocker for this PR but it would be nice if the settings where enabled/disabled are the only states could be replaced with checkboxes (even better if they could be replaced with on/off toggles -- I think they're called radio switches, not sure)...

Yeah they're switches. I would love to remove check boxes at some point in favor of switches but I'm currently waiting on an issue with the Android Gradle Plugin to be resolved.

@JosJuice JosJuice merged commit 7743afd into dolphin-emu:master Oct 23, 2022
11 checks passed
@t895 t895 deleted the convert-layout branch January 1, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants