HW: Pass System to MMIO handlers. #11166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
mmio-system
branch
from
fa93c7e
to
8a35576
Compare
|
Uuh, need some help with the ARM ASM here. |
AdmiralCurtiss
force-pushed
the
mmio-system
branch
from
8a35576
to
dd7b9b7
Compare
JosJuice
reviewed
Oct 15, 2022
AdmiralCurtiss
force-pushed
the
mmio-system
branch
from
dd7b9b7
to
60470ed
Compare
AdmiralCurtiss
force-pushed
the
mmio-system
branch
from
60470ed
to
32ef02e
Compare
AdmiralCurtiss
force-pushed
the
mmio-system
branch
from
32ef02e
to
0a6fdb9
Compare
lioncash
reviewed
Nov 23, 2022
| Fifo::SyncGPUForRegisterAccess(); | ||
| WriteHigh(fifo.CPReadPointer, val & WMASK_HI_RESTRICT); | ||
| })); | ||
| mmio->Register( |
There was a problem hiding this comment.
Kind of a pre-existing thing, but maybe extract the lambdas into const locals, so the formatting is a little nicer to read (if it can be done). If it can't be done nicely, then I wouldn't worry about it.
There was a problem hiding this comment.
545fee9 is the best I can come up with, is that better? It definitely formats nicer at least.
AdmiralCurtiss
changed the title
lioncash
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
De-globalizing the MMIO handlers.
I'd like some input here on if this is a good way to do it. The only other approach I can think of would be to capture the system instance in every single complex handler, which IMO is worse, but ymmv.