Jit64: Add dispatcher_no_timing_check jump target #11170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `dispatcher_no_timing_check` is the same as `dispatcher_no_check` except it includes the "stepping check" in debug mode. This lets us avoid the `m_enable_debugging ? dispatcher : dispatcher_no_check` dance.
|
@AdmiralCurtiss This should fix the problem you mentioned where we sometimes jump to |
degasus
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The new
dispatcher_no_timing_checkis the same asdispatcher_no_checkexcept it includes the "stepping check" in debug mode. This lets us avoid them_enable_debugging ? dispatcher : dispatcher_no_checkdance.