Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: Simplify IOS::HLE::Device savestate method #11177

Merged

Conversation

Lobsterzelda
Copy link
Contributor

There was an extra call to p.do(m_is_active) in IOS::HLE::Device::DoState(). This PR eliminates that extra call, and simplifies the DoState() method for the Device class.

@Lobsterzelda Lobsterzelda force-pushed the simplify-device-save-state branch 2 times, most recently from 6e49ef9 to 42d0bda Compare October 18, 2022 03:05
@Lobsterzelda Lobsterzelda changed the title Device: Simplify IOS::HLE::Device savestate method IOS: Simplify IOS::HLE::Device savestate method Oct 18, 2022
Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, looks good to me though and I locally confirmed that Device::DoState is now called (either directly or through USBHost::DoState or by not overriding DoState at all) for all devices.

@leoetlino leoetlino merged commit ee5a93c into dolphin-emu:master Oct 18, 2022
11 checks passed
@Lobsterzelda Lobsterzelda deleted the simplify-device-save-state branch October 20, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants