MemoryWidget: Make search address a combobox that holds address history. #11185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Always update the combobox when a new target address is sent.
The main problem was that navigating to an address from another widget wouldn't update the address box. It worked for peeking at a section, then going back to the original, unchanged search address, but not much else. I added a 10 slot history of addresses so you could keep your old address. All navigated to addresses (from other widgets) will go into the text box and history box automatically and the original address that gets overwritten will be saved in the combo box too.
Two issues in doing this were the offset box and typed addresses. The offset box is too cumbersome to worry about imo, selecting an address from the combobox will add the offset box to it. Typed addresses don't feel like they should immediately be added to the history box. If you press ENTER it will go into the history.