Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoBackends:Metal: Default to presentDrawable when vsync is on #11205

Merged
merged 1 commit into from Jan 30, 2023

Conversation

TellowKrinkle
Copy link
Contributor

I added the presentDrawable option in #11028 and it looks like it improves frame pacing on 60hz displays, so default it on when vsync is on, since it looks like we disable vsync during fast forward

@dvessel could you test and see if it works without the special config option now? (You'll still need to force 59.94hz)

And then make sure fast forward still works

Note: This means users of <60hz displays will have to set MTLUsePresentDrawable=0 in their configs. Hopefully most people have ≥60hz displays.

@dvessel
Copy link
Contributor

dvessel commented Oct 25, 2022

Ever since I updated to Ventura, the frame pacing at a fixed refresh rate has been perfect. This is without the special config flag and on builds that didn’t include #11028. This could be useful to others not on Ventura but I wouldn’t know.

Fast forward always worked when I tested it in Monterey with the special config flag but IIRC, it was limited to 200%. I forget which condition limited it to 200% fast forward but fast forward always worked regardless.

@TellowKrinkle
Copy link
Contributor Author

Ever since I updated to Ventura, the frame pacing at a fixed refresh rate has been perfect. This is without the special config flag and on builds that didn’t include #11028. This could be useful to others not on Ventura but I wouldn’t know.

Yeah, it sounds like Ventura fixes the issue for the existing method ([drawable present]) and also fixes the issue where [cmdbuffer presentDrawable:] caps at the screen refresh rate, but it would be nice to have this for any Intel Macs that aren't supported on Ventura.

@pizuz
Copy link

pizuz commented Oct 26, 2022

I‘d have been able to test this on my Catalina box, but ”unfortunately“ I just OCLPd it to Ventura. Works great, by the way. Highly recommendable if your system is supported.

@delroth delroth merged commit a2f4606 into dolphin-emu:master Jan 30, 2023
11 checks passed
@TellowKrinkle TellowKrinkle deleted the AutoPresent branch January 30, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants