JIT: fix fsel/ps_sel implementations for NaN input #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FioraAeterna
force-pushed
the
fixfsel
branch
from
8ae94ef
to
9137b45
Compare
fselx was the main problem, but ps_sel was wrong too (even if there were no known reported bugs with it). This fixes Beyond Good and Evil (at the least).
FioraAeterna
force-pushed
the
fixfsel
branch
from
9137b45
to
c130a49
Compare
|
Get wrecked Beyong Good and Evil. |
Sonicadvance1
added a commit
that referenced
this pull request
Sep 20, 2014
JIT: fix fsel/ps_sel implementations for NaN input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes Beyond Good and Evil (at the least).
The logic necessary to get the conditions right here is really subtle (I /hope/ I got it right, I tested it in a separate program) and I pounded my head against it for like 3 hours, so I left a detailed comment explaining it.