Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacUpdater: check os version #11220

Merged
merged 2 commits into from Oct 30, 2022
Merged

MacUpdater: check os version #11220

merged 2 commits into from Oct 30, 2022

Conversation

shuffle2
Copy link
Contributor

uses the bundle version instead of build_info.txt

@shuffle2 shuffle2 force-pushed the macversion branch 3 times, most recently from d36c15b to b304b4d Compare October 27, 2022 21:26
@shuffle2
Copy link
Contributor Author

@OatmealDome plz check the objc code actually works (for example I'm not totally sure the Dolphin.app path is even correct). Just pinging as a way to add you as reviewer...

Source/Core/MacUpdater/MacUI.mm Outdated Show resolved Hide resolved
Source/Core/MacUpdater/MacUI.mm Outdated Show resolved Hide resolved
Source/Core/MacUpdater/MacUI.mm Outdated Show resolved Hide resolved
@OatmealDome
Copy link
Member

Haven't tried yet, but will do shortly...

@shuffle2 shuffle2 force-pushed the macversion branch 2 times, most recently from 6e9792a to 2544415 Compare October 30, 2022 03:38
@shuffle2 shuffle2 force-pushed the macversion branch 2 times, most recently from bd11546 to 06a752d Compare October 30, 2022 19:03
@JMC47 JMC47 merged commit 969309c into dolphin-emu:master Oct 30, 2022
11 checks passed
@shuffle2 shuffle2 deleted the macversion branch October 30, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants