JitArm64: Move MMIO handler result before popping stack #11227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we might throw the result away. Fixes https://bugs.dolphin-emu.org/issues/13083.
Because of the previous commit, `regs_in_use` must not include `dest_reg` when calling MMIOLoadToReg. There are also some other registers we can skip including in regs_in_use just for efficiency's sake. The `addr_reg_set = false` statements that I've added in this commit are technically redundant – if `mmio_address` is non-zero then `addr_reg_set` is already false – but it's just a coincidence that that's the case.
|
It stalls in RSII & III with the MMU being enabled. I forced it on for other games and ran into the same problem so it’s what is triggering the bug. This fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Otherwise we might throw the result away. Fixes https://bugs.dolphin-emu.org/issues/13083.