GCMemcardDirectory: GCI filename cleanup and fixes. #11230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
Oct 30, 2022
iwubcode
reviewed
Oct 30, 2022
AdmiralCurtiss
force-pushed
the
gci-filenames
branch
2 times, most recently
from
954be73
to
948261c
Compare
|
@JMC47 Can you check if this fixes https://bugs.dolphin-emu.org/issues/12999? |
AdmiralCurtiss
force-pushed
the
gci-filenames
branch
from
948261c
to
defccad
Compare
This is cheaper and more accurate than comparing default GCI filenames.
…heir identity instead of their default filename.
AdmiralCurtiss
force-pushed
the
gci-filenames
branch
from
5a1880b
to
1089d3c
Compare
|
Likewise, does someone want to look at this? It should be pretty straightforward. |
iwubcode
reviewed
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Intended to fix issue 12999, though I don't know whether it actually does.