Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: Rename: use std::filesystem::rename for posix behavior #11231

Merged
merged 1 commit into from Oct 30, 2022
Merged

windows: Rename: use std::filesystem::rename for posix behavior #11231

merged 1 commit into from Oct 30, 2022

Conversation

shuffle2
Copy link
Contributor

@shuffle2 shuffle2 commented Oct 30, 2022 •
edited

this should™ fail less and behave more like posix rename()

intended to fix https://bugs.dolphin-emu.org/issues/13093 , hopefully fixes more stuff as well..

@shuffle2 shuffle2 changed the title Rename: use MoveFileEx(..COPY_ALLOWED|REPLACE_EXISTING|WRITE_THROUGH) windows: Rename: use std::filesystem::rename for posix behavior Oct 30, 2022
iwubcode
iwubcode approved these changes Oct 30, 2022
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One step closer to a 100% std::filesystem Dolphin! LGTM. Untested.

@JMC47 JMC47 merged commit f277a92 into dolphin-emu:master Oct 30, 2022
11 checks passed
@shuffle2 shuffle2 deleted the updater branch October 30, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@shuffle2 @iwubcode @JMC47