NetPlay: Split SyncSaveData() into two parts. #11233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone review this? Someone ran into this again on discord today. |
leoetlino
reviewed
Nov 5, 2022
Source/Core/Core/NetPlayServer.cpp
Outdated
| m_saves_synced = false; | ||
|
|
||
| m_save_data_synced_players = 0; | ||
|
|
||
| u8 save_count = 0; |
There was a problem hiding this comment.
I realise this is existing code, but why is this an u8? Seems like int or size_t would be a more natural choice?
There was a problem hiding this comment.
I'm guessing it was like that because it's sent over the network, so it needs a fixed size, and it never exceeds 7 (2 GC slots, all Wii stuff just counts as 1, and 4 GBA slots). It's then used as a counter for how many 'saves' have successfully synced on the client side. An odd variable in general really, there's probably better ways to handle this, not sure how much I want to mess with this logic here though...
This allows the 'save collection' part to run even if no clients are connected. Fixes issue 13095.
AdmiralCurtiss
force-pushed
the
netplay-split-save-sync-function
branch
from
dc15ac8
to
e9caa09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This allows the 'save collection' part to run even if no clients are connected. Fixes issue 13095, if we interpreted that one correctly anyway.