VideoBackends:Vulkan: Fix 0 size descriptor pools #11238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
@K0bin - can you add that validation error to the commit message? |
[ VUID-VkDescriptorPoolCreateInfo-maxSets-00301 ] Object 0: handle = 0x7f1,b8d,3cd,e70, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xa1,70e,236 | vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0. The Vulkan spec states: maxSets must be greater than 0
K0bin
force-pushed
the
zero-descriptor-size
branch
from
0bc848f
to
f5fecaf
Compare
|
Done @iwubcode |
iwubcode
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes: