VideoCommon: Zero PortableVertexDeclarations on initialization #11246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Nov 3, 2022
TellowKrinkle
force-pushed
the
PVDMemset
branch
from
2353b47
to
6ce8f00
Compare
iwubcode
approved these changes
Nov 3, 2022
lioncash
reviewed
Nov 4, 2022
Fixes an issue where the default initializer wouldn't initialize padding, making for fun non-determinism
TellowKrinkle
force-pushed
the
PVDMemset
branch
from
6ce8f00
to
d9ed9ae
Compare
TellowKrinkle
added a commit
to TellowKrinkle/fifoci
that referenced
this pull request
Nov 12, 2022
…and mipmapping Early memory updates should no longer be needed as of dolphin-emu/dolphin#11246 Disabling mipmapping works around an issue in M1-non-pros where the edges of triangles pick up wrong mip levels every now and then (see https://github.com/tellowkrinkle/MetalBugReproduction/releases/tag/BrokenMipmapRender) Manual texture sampling was enabled in an attempt to work around the mipmapping issue, but didn't end up helping. I'm guessing issue is actually in the derivative calculation, rather than the sampling operation itself.
delroth
pushed a commit
to dolphin-emu/fifoci
that referenced
this pull request
Nov 13, 2022
…and mipmapping Early memory updates should no longer be needed as of dolphin-emu/dolphin#11246 Disabling mipmapping works around an issue in M1-non-pros where the edges of triangles pick up wrong mip levels every now and then (see https://github.com/tellowkrinkle/MetalBugReproduction/releases/tag/BrokenMipmapRender) Manual texture sampling was enabled in an attempt to work around the mipmapping issue, but didn't end up helping. I'm guessing issue is actually in the derivative calculation, rather than the sampling operation itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The default compiler-generated initializer isn't required to initialize padding, making for fun non-determinism when playing back fifologs
See: https://gcc.godbolt.org/z/vev3n47d9
Note: I'm not sure the compiler-generated copy constructor is required to copy padding either, but all notable C++ compilers do, and we static_assert that PortableVertexDeclaration is trivially copyable
(Fixes the random missing textures on the M1 fifoplayer)