Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Offload cover path unmangling to another thread #11248

Merged
merged 1 commit into from Nov 13, 2022

Conversation

t895
Copy link
Contributor

@t895 t895 commented Nov 4, 2022

As mentioned by @JosJuice in #11245, I have offloaded the unmangling of the custom cover path to another thread.

(On UI Thread)
Performance Before -
image

Performance After -
image

@JosJuice
Copy link
Member

JosJuice commented Nov 4, 2022

Is there a reason why the Glide call has to happen on the main thread? I'm particularly thinking about the fact that File.exists is being called on the main thread. (It's faster than unmangle, but it still has to hit the file system.) Though I suppose if the Glide call does have to happen on the main thread, you could move just the File.exists call to the unmangle thread.

@t895
Copy link
Contributor Author

t895 commented Nov 4, 2022

Is there a reason why the Glide call has to happen on the main thread? I'm particularly thinking about the fact that File.exists is being called on the main thread. (It's faster than unmangle, but it still has to hit the file system.) Though I suppose if the Glide call does have to happen on the main thread, you could move just the File.exists call to the unmangle thread.

Yeah Glide has to be called on the main thread because it posts the result to the imageView. But I'll just move the File.exists call to make things a little better.

@JosJuice JosJuice merged commit 2340a7e into dolphin-emu:master Nov 13, 2022
11 checks passed
@t895 t895 deleted the offload-unmangle branch January 1, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants