Boot: Load DOL/ELF after memory setup #11249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently talked to a homebrew developer who was trying to add exception handlers at link time but found out that Dolphin was overwriting their exception handlers. I figure that's not the usual way to do exception handlers, but... making us load the executable after setting up memory rather than before is easy, and matches what we do when booting discs, so I suppose there's no reason not to do it. It also matches the intent of why Dolphin is writing default exception handlers – we're writing them because some homebrew relies on exception handlers being left around from whatever program was running before it (see 3dd777b).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I recently talked to a homebrew developer who was trying to add exception handlers at link time but found out that Dolphin was overwriting their exception handlers. I figure that's not the usual way to do exception handlers, but... making us load the executable after setting up memory rather than before is easy, and matches what we do when booting discs, so I suppose there's no reason not to do it. It also matches the intent of why Dolphin is writing default exception handlers – we're writing them because some homebrew relies on exception handlers being left around from whatever program was running before it (see PR #6247).