Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Use FrameLayout as root for notouch emulation layout #11251

Merged
merged 1 commit into from Nov 6, 2022

Conversation

t895
Copy link
Contributor

@t895 t895 commented Nov 6, 2022

When inflating this layout, the layout inflater doesn't expect a View and rather a descendant of ViewGroup. This resulted in a crash which is resolved by using a FrameLayout instead.

Basically, running the emulation activity on an Nvidia Shield (or any device without a touchscreen) will crash without this fix.

When inflating this layout, the layout inflater doesn't expect a View and rather a descendant of ViewGroup. This resulted in a crash which is resolved by using a FrameLayout instead.
@t895 t895 changed the title Android: Use FrameLayout as root for notouch emulation Android: Use FrameLayout as root for notouch emulation layout Nov 6, 2022
@JosJuice JosJuice merged commit 1a51107 into dolphin-emu:master Nov 6, 2022
11 checks passed
@t895 t895 deleted the notouch-fix branch January 1, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants