CoreTiming: Pass Core::System to Events. #11253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
Nov 6, 2022
| @@ -270,7 +270,7 @@ void UpdateInterrupts() | |||
| ProcessorInterface::SetInterrupt(ProcessorInterface::INT_CAUSE_EXI, causeInt); | |||
| } | |||
|
|
|||
| static void UpdateInterruptsCallback(u64 userdata, s64 cycles_late) | |||
| static void UpdateInterruptsCallback(Core::System& system, u64 userdata, s64 cycles_late) | |||
There was a problem hiding this comment.
Just curious but what was this added for? Consistency I guess?
There was a problem hiding this comment.
It won't compile unless the function signature of this callback matches.
There was a problem hiding this comment.
Can't pass a function pointer unless the signature matches.
There was a problem hiding this comment.
Thank you both, hadn't gotten that far in my investigation yet. That makes sense!
lioncash
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
More steps towards de-globalization.