Android: Animate covers on focus change #11256
Merged
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
approved these changes
Nov 6, 2022
|
It would probably be better to cache the animations and not reload them every time. |
t895
force-pushed
the
animate-focus-change
branch
from
6fb7780
to
bfcddd3
Compare
Got it |
K0bin
approved these changes
Nov 6, 2022
JosJuice
reviewed
Nov 6, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/adapters/GameAdapter.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: JosJuice <josjuice@gmail.com>
t895
force-pushed
the
animate-focus-change
branch
from
89701b5
to
60fb151
Compare
|
The grey colour in the demo isn't amazing, it's a little dark so black text on mid grey background is pretty eh, but that's an easy detail to fix later. The animation itself is good. LGTM. |
Yeah that's just the default "focus" color in Android. I'll find something better later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Subtle animation when using controller navigation.
