ImGui render context race condition fix: Lock context during Init/Shutdown. #11258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ImGui::GetIO` performs an assertion that a context exists, and if one doesn't then things will likely crash. Unfortunately this crash is hard to consistently reproduce.
|
I think it was probably needing to split |
|
I agree that is a bit odd, but I don't really know the rendering logic well enough to say whether it's possible for that to be executed at an inopportune time, so... I guess it's fine for now? |
|
Better than it was before, in any case. |
|
Reporter confirmed that this fixes their problem, so I'm gonna merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix for https://bugs.dolphin-emu.org/issues/12652. Includes the commit from #10458.
@Pokechu22 As far as I can tell this works fine, can you see if you can figure out why you thought you couldn't acquire the lock during shutdown?