Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Change system update dialog title/message when cancelling #11266

Merged
merged 1 commit into from Nov 11, 2022
Merged

Android: Change system update dialog title/message when cancelling #11266

merged 1 commit into from Nov 11, 2022

Conversation

t895
Copy link
Contributor

@t895 t895 commented Nov 11, 2022

This PR doesn't affect the speed of cancelling updates. It's just better UX since the update can take a while to cancel at times.

Before -
cancel-demo

After -
cancel-demo-new

Simonx22
Simonx22 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@Simonx22 Simonx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

@MayImilae
Copy link
Contributor

Much better.

@JosJuice JosJuice merged commit bf69a0b into dolphin-emu:master Nov 11, 2022
11 checks passed
@t895 t895 deleted the alert-dialog-cancel branch January 1, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simonx22 Simonx22 Simonx22 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@t895 @MayImilae @Simonx22 @JosJuice