Rename "Keyboard" to "Keyboard Controller"

[jordan-woyak]

Some confused users choose "Keyboard" instead of "Standard Controller" when then intend to play with a keyboard.

This renames "Keyboard" to "Keyboard Controller" and adds some warning text to the mapping dialog.

[JosJuice]

I was considering renaming it in this way at one point, but then someone pointed out to me that this keyboard actually has two SKUs, one released by ASCII and one released by Sammy. That made me kind of indecisive. What do you think?

[jordan-woyak]

I was considering renaming it in this way at one point, but then someone pointed out to me that this keyboard actually has two SKUs, one released by ASCII and one released by Sammy. That made me kind of indecisive. What do you think?

Ah, I wasn't aware of the Sammy version. I guess I can just remove "ASCII " and hopefully "Keyboard Controller" plus the warning will help?

[JosJuice]

Sure. The warning especially seems like a good idea. Maybe add the yellow warning icon that we're currently showing if you try to add a cheat without having turned on "Enable Cheats"?

[Rumi-Larry]

A checkmark to "never show this warning again" would be useful if you are a frequent Phantasy Star player

[jordan-woyak]

A checkmark to "never show this warning again" would be useful if you are a frequent Phantasy Star player

I disagree. It's just text on the dialog. I think it should always be visible to deter the confused users.
Actual PSO players won't be bothered by it.

[AdmiralCurtiss]

Sounds good to me.

[Rumi-Larry]

The title of this PR should include "... and added warning"

[MayImilae]

Definitely a good idea. However, I'd suggest changing the warning slightly to:

You are configuring a "Keyboard Controller", a unique controller exclusively supported by Phantasy Star Online. If you just want to use your keyboard to play games, turn back and configure a "Standard Controller".

Btw I changed "Phantasy Star Online Episode I & II" to just "Phantasy Star Online" because there is an Ep3 and it also supports the keyboard controller. Specifying the versions just gets weird.

[MayImilae]

Minimizing You language a bit gives this.

This is the configuration page for the "Keyboard Controller", a unique controller exclusively supported by Phantasy Star Online. If you just want to use your keyboard to play games, turn back and configure a "Standard Controller".

I'm not sure if it is better, and I can't totally eliminate yous in this. But it is good to avoid yous as much as we can.

[stblr]

This device is exclusively for PSO.

Homebrew software can also make use of it (at least we do so in mkw-sp).

[MayImilae]

Homebrew software can also make use of it (at least we do so in mkw-sp).

For brevity, it's best not to mention that. If you are bothered by this we could drop the word "exclusively", but by adding that word it helps people get the message "am I playing PSO? No? Then this is probably the wrong thing." I'd like to keep it.

[jordan-woyak]

Considering homebrew is why I originally said "exclusively for" PSO rather than "exclusively supported by" PSO, which is maybe more correct since the controller was really only designed for PSO, but other things can use it. I don't think we need to explicitly mention homebrew. Anyone who understands what this device is will not be confused. The warning just needs to scare users away that have no use for a "Keyboard Controller".

[MayImilae]

"Exclusively for" is perfectly fine.

[Dentomologist]

I made this mistake when I first started using Dolphin, but I think I would have interpreted "Keyboard Controller" as "Use your keyboard as the controller" which would have led me to make the same mistake. If the pulldown menu option were "Phantasy Star Online Keyboard" or something the intent would be more explicit.

The configuration warning is a partial fix, but still requires the user to select and try to configure the wrong option which isn't ideal.

The other half of the problem is more subjective and outside the scope of this PR but I think it's worth mentioning. When I saw Standard Controller my assumption was that referred to a physical GameCube controller plugged in via adapter, and likewise for the other options. The Wii U option does explicitly mention an adapter, but I figured that was a special adapter supporting Wii U peripherals instead of a more standard one.

I don't know what the best way to address that would be, but if the menu had been divided into "Physical Controller" and "Emulated Controller" sections I think that would have been much clearer to me, and probably other people making this mistake.

[mbc07]

I noticed an oddity: the message tries to keep itself centered on the empty space when you resize the controller window vertically, resulting in the top/bottom padding of the message proportionally increasing to account for that. I think it would be better to mimic the behavior of the message from the Motion Input tab of Wiimotes, where the vertical size is fixed and additional empty space is added at the bottom of all bindings when resizing the window vertically...