Android: Add theme mode switcher #11270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t895
force-pushed
the
theme-mode
branch
5 times, most recently
from
34d074f
to
e897fba
Compare
Similar to app themes, theme modes have to be loaded before directory initialization is ready. So we save the proper key the same way.
lioncash
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Now you can chose the theme mode independent of the system. This also allows all Android versions to use a dark theme now. The system-wide toggle was only introduced in Android 10 so users below that version can enjoy this now. This also includes AndroidTV users who used to be stuck with the mode mismatch between the main and settings UI.
Note - Similar to app themes, theme modes have to be loaded before directory initialization is ready. So we save the proper key the same way.
Demo -
