Debugger: add callstack to conditional breakpoints #11273
Conversation
TryTwo
force-pushed
the
PR_Conditional_BP_Callstack
branch
2 times, most recently
from
0d015e4
to
505b286
Compare
|
@smurf3tte How does this look to you? |
TryTwo
force-pushed
the
PR_Conditional_BP_Callstack
branch
from
505b286
to
a9ad0b7
Compare
|
@smurf3tte Thanks so much for the help! I don't actually know any C coding, so I guess it was a bit more haphazard than I thought. I would like to get it correct and I think I fixed most of your issues. Need a bit of help on a few though, as noted. |
TryTwo
force-pushed
the
PR_Conditional_BP_Callstack
branch
from
a9ad0b7
to
6ccdbd7
Compare
|
I think I fixed everything mentioned |
|
I don't know what formatting you applied to expr.h, but it wasn't using Dolphin's .clang-format file. Either the formatting should match the rest of Dolphin or it should be left alone, IMO. Note that Dolphin's .clang-format file is under the Source subdirectory, so it won't be applied to source files under Externals by the lint script or by IDEs like Visual Studio. If you want to apply Dolphin's formatting, the easy thing to do would be to copy the .clang-format file to the expr subdirectory (but don't check it in). |
|
Thanks for pointing out the formatting. I didn't realize it was doing something arbitrary. I just didn't want to format my changes manually , because I'd probably mess something up. I'll fix the things then make a separate push to fix the formatting. |
TryTwo
force-pushed
the
PR_Conditional_BP_Callstack
branch
2 times, most recently
from
55cc48d
to
81ece41
Compare
|
I think I returned to the original formatting. It formatted a few lines near the top, but everything else was unchanged. |
TryTwo
force-pushed
the
PR_Conditional_BP_Callstack
branch
from
81ece41
to
4e8f1c8
Compare
|
Made a few more tweaks to try and keep the coding style consistent. |
Use: callstack(0x80000000).
!callstack(value) works as a 'does not contain'.
Add strings to expr.h conditionals.
Use quotations: callstack("anim") to check symbols/name.
TryTwo
force-pushed
the
PR_Conditional_BP_Callstack
branch
from
4e8f1c8
to
76bf1b5
Compare
|
Thanks so much for all the help!! |
callstack(0x80123456) returns true if the callstack has an address equal to that value.
callstack("anim") returns true if the callstack contains text equal to the quoted word.
With symbols from address and callstack("80123456"), it will be true if the function that begins at that address is in the callstack. Plus it should return true on anything that the unquoted version returns true for.
!callstack("anim") returns true if the callstack does not contain the text anim.
Had to add string support to expr.h. Strings are flagged by being inside quotations. Strings will return NAN if assigned to a variable or checked for a (double) value.