Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon/FramebufferManager: Further EFB cache cleanup #11280

Merged
merged 3 commits into from Nov 16, 2022

Conversation

Pokechu22
Copy link
Contributor

A follow-up to #11172.

…pth peeks

0e02ddc removed separate logic for tiled versus non-tiled EFB peek caches, and as part of that made it so that color peeks updated the frame access mask even when a non-tiled cache is in use. However, the same change was not made for depth peeks. I'm not sure if this affected anything in practice.
…CacheTileRect

This is for readability only, and should behave identically.
…b_cache_tile_row_stride

This also initializes it in the non-tiled case just for consistency, although it's not actually read in that case.
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Untested

@AdmiralCurtiss AdmiralCurtiss merged commit 99a918d into dolphin-emu:master Nov 16, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants