Netplay: Check if save is readable before marking it for sync. #11284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
netplay-save-sync-check-corrupted
branch
from
4e2ab84
to
39142fa
Compare
AdmiralCurtiss
force-pushed
the
netplay-save-sync-check-corrupted
branch
from
39142fa
to
752004e
Compare
AdmiralCurtiss
force-pushed
the
netplay-save-sync-check-corrupted
branch
from
752004e
to
7adeb73
Compare
AdmiralCurtiss
force-pushed
the
netplay-save-sync-check-corrupted
branch
from
7adeb73
to
eb31b3b
Compare
AdmiralCurtiss
force-pushed
the
netplay-save-sync-check-corrupted
branch
from
eb31b3b
to
c09bcfc
Compare
AdmiralCurtiss
force-pushed
the
netplay-save-sync-check-corrupted
branch
2 times, most recently
from
cce4575
to
e973dc3
Compare
AdmiralCurtiss
force-pushed
the
netplay-save-sync-check-corrupted
branch
from
e973dc3
to
10207bb
Compare
|
I originally wanted to make a better check here and maybe an alternate sync mode for such saves, but clearly I never got the motivation for that, so maybe we should just merge this so the 'sync all wii saves' mode works if you have a installed Wii menu... |
|
Can we get a review on this then? |
AdmiralCurtiss
force-pushed
the
netplay-save-sync-check-corrupted
branch
from
10207bb
to
b94a715
Compare
AdmiralCurtiss
force-pushed
the
netplay-save-sync-check-corrupted
branch
from
b94a715
to
00e4fc4
Compare
|
Guess no one wants to so I'll just merge it, can't be much worse than Netplay failing to start completely like it does on master right now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Test build for the user mentioned in #11283.