VideoBackends: Query fixes and cleanups #11286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0bin
force-pushed
the
vk-query-fix
branch
2 times, most recently
from
f691694
to
0d60acb
Compare
iwubcode
reviewed
Nov 16, 2022
K0bin
force-pushed
the
vk-query-fix
branch
2 times, most recently
from
436ffc8
to
1e9adc2
Compare
iwubcode
reviewed
Nov 19, 2022
Fixes both checking whether queries are done and actually resets query pools.
HOST barriers need to be issued regardless of whether the memory type is coherent and we need to properly synchronize writes to the buffer.
|
This seems to also affect D3D12, which should be reflected in the title. |
|
Done |
|
Is this good to go? |
|
As far as I'm concerned: yes. |
|
Been sitting for a couple of weeks. I did a quick test and it seems fine. I figure this meant perfqueries, so I tested Super Mario Sunshine and the beach worked as per usual. Couldn't test D3D12 since I'm on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Queries in the Vulkan renderer are completely broken right now:
This seems to have be a regression caused by 604ab67.
The last commit is somewhat unrelated but it's something I noticed.