DolphinQt: Add GBA TAS input window #11291
Merged
+164
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
gba-tas-input
branch
from
92c3ab3
to
415f56c
Compare
iwubcode
reviewed
Nov 20, 2022
When emulated GBAs were added to Dolphin, it was possible to control them using the GC TAS input window. (Z was mapped to Select.) Unaware of this, I broke the functionality in b296248. To make it possible to control emulated GBAs using TAS input again, I'm adding a proper TAS input window for GBAs, with a real Select button and no analog controls.
JosJuice
force-pushed
the
gba-tas-input
branch
from
415f56c
to
40571cf
Compare
iwubcode
approved these changes
Nov 22, 2022
|
Can't be worse than broken, I suppose. |
|
I had this tested by a TASer FWIW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When emulated GBAs were added to Dolphin, it was possible to control them using the GC TAS input window. (Z was mapped to Select.) Unaware of this, I broke the functionality in b296248.
To make it possible to control emulated GBAs using TAS input again, I'm adding a proper TAS input window for GBAs, with a real Select button and no analog controls.