CoreTiming: Refactor to class. #11303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
coretiming-class
branch
5 times, most recently
from
dd1dfa1
to
3639712
Compare
lioncash
reviewed
Nov 26, 2022
AdmiralCurtiss
force-pushed
the
coretiming-class
branch
from
3639712
to
daa7053
Compare
lioncash
approved these changes
Nov 27, 2022
This was referenced Apr 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already mused about this in #11301 but that got merged before I was done...
This is more conventional than the get-state-from-System approach and forces the caller to actually 'pass' the state (by having the instance), and in some cases we already have the System instead of having to fetch the Singleton!