Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Upgrade AGP to 7.3.1 #11309

Merged
merged 1 commit into from Dec 8, 2022
Merged

Conversation

t895
Copy link
Contributor

@t895 t895 commented Nov 28, 2022

We're currently running AGP 7.0.4 because of broken incremental builds as documented here https://issuetracker.google.com/issues/232060576?pli=1

However, upgrading to the latest version comes with several benefits that should be considered even when dealing with this bug.
This release will allow us to -

  • Upgrade to MDC 1.7.0 with the new MaterialSwitch component and changes to navigation bars that will help in my work on larger layouts
  • Use Baseline Profiles that will make initial app performance much more consistent (~30% faster launch times)
  • Avoid undocumented behavior since AGP 7.0.4 only supports up to API 31 and we're compiling for API 33 now

@shuffle2
Copy link
Contributor

shuffle2 commented Nov 29, 2022

The bug will break the android buildbot...so unless it's fixed I don't see how this is mergeable(?)

I guess you could change android build to do full clean build each time, with a comment linking to the bug, or something.

@t895
Copy link
Contributor Author

t895 commented Nov 29, 2022

I guess you could change android build to do full clean build each time, with a comment linking to the bug, or something.

Is there a way to send a command to the buildbot to only do a full clean build of the android version when we need it?

@shuffle2
Copy link
Contributor

you'd probably have to make the change on https://github.com/dolphin-emu/sadm (+ maybe the build files in this repo), or hack in a modification directly on the android buildbot server.

@t895
Copy link
Contributor Author

t895 commented Nov 29, 2022

Huh, I guess it's time to learn how the buildbot works

@t895
Copy link
Contributor Author

t895 commented Dec 8, 2022

Since this was merged, we can go ahead here now.

@JosJuice JosJuice merged commit abf08b5 into dolphin-emu:master Dec 8, 2022
11 checks passed
@t895 t895 deleted the agp-upgrade branch January 1, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants